feat: Accouting Service (WIP) #428
Conversation
fforbeck
force-pushed
the
feat/egress-tracking
branch
from
e679e7e to
5872799
Compare
View stack outputs
|
fforbeck
force-pushed
the
feat/egress-tracking
branch
from
402bd89 to
59868d0
Compare
fforbeck
force-pushed
the
feat/egress-tracking
branch
from
385cd1c to
50ee065
Compare
|
|
||
| // simulate the SQS event that triggers the handler | ||
| // FIXME (fforbeck): why the events are not collected? | ||
| const collected = await collectQueueMessages(ctx.egressQueue) |
There was a problem hiding this comment.
@travis, do you have any ideas on why it would not collect the events from the queue?
| })) | ||
| } | ||
|
|
||
| const response = await ctx.egressHandler(sqsEvent, ctx) |
There was a problem hiding this comment.
@travis, Do you have any suggestions on how to test the handler?
There was a problem hiding this comment.
per my comment below, we may not need this at all - happy to chat more!
| assert.equal(record.ok.results[0].resourceId, e.resourceId) | ||
| assert.equal(record.ok.results[0].timestamp, e.timestamp) | ||
| } | ||
| // FIXME (fforbeck): how to check we send the events to stripe? |
There was a problem hiding this comment.
@travis, How we can test if the Stripe Usage Record API is being called for each event?
There was a problem hiding this comment.
goooood question - I think the most sophisticated test logic we have for stripe is here:
https://github.com/storacha/w3infra/blob/main/upload-api/test/billing.test.js
it might be worth trying to use this:
https://github.com/stripe/stripe-mock
but I don't think we've used it for anything yet
it's also worth looking into this:
https://docs.stripe.com/billing/testing
high level though I think our Stripe testing overall can be improved! happy to kick around ideas for this!
| */ | ||
| async function sendRecordUsageToStripe(stripe, egressEvent) { | ||
| const subscriptionItem = { | ||
| id: 'sub_123', // FIXME (fforbeck): |
There was a problem hiding this comment.
@travis, we currently don't have this subscriptionItem information available. I was wondering if that would be the exact same ID for all the customers, or if we can find it per customer somehow.
There was a problem hiding this comment.
it's going to be different for each customer - I think this is the interface you're looking for - it should let you find a Stripe ID (account in that interface) given one of our customer IDs (customer in that interface) - the naming is a little confusing given that we call "customer IDs" "accounts" in other places - sorry about that!
|
I still owe this a close review, but high level wanted to mention that as I've been thinking about this I've come to think this should probably be sitting behind a UCAN invocation, largely because I think we want to be able to show receipts to customers that are signed by the gateway. I'm imagining a capability like we already have https://github.com/storacha/w3up/blob/main/packages/capabilities/src/usage.js given this we can probably just get rid of the SQS queue - I'm not sure it adds much if each of these invocations is handled by a separate lambda anyway |
|
Closing. New PR: #430 |
Add Accounting Service for Egress Metrics Tracking
This PR introduces a new accounting service to track egress metrics for billing purposes. The service integrates with both DynamoDB and Stripe to ensure accurate and efficient billing for our customers.
Key Features:
DynamoDB Integration:
Stripe Integration:
Next Steps:
Tasks: